Fix GH-23447: segfault when the SoapServer class fails to initialize - #23448
Closed
lazerg wants to merge 3 commits into
Closed
Fix GH-23447: segfault when the SoapServer class fails to initialize#23448lazerg wants to merge 3 commits into
lazerg wants to merge 3 commits into
Conversation
devnexen
reviewed
Aug 25, 2026
| --TEST-- | ||
| GH-23447 (Segfault when a class passed to SoapServer::setClass() fails to initialize) | ||
| --EXTENSIONS-- | ||
| soap |
Member
There was a problem hiding this comment.
nit adding proper CREDITS here
Contributor
Author
There was a problem hiding this comment.
Both fixed in 0d0ffd9: added the CREDITS entry and switched to [] array syntax.
| private $broken = undefinedConstant; | ||
| } | ||
|
|
||
| $server = new SoapServer(null, array('uri' => 'http://testuri.org')); |
Member
There was a problem hiding this comment.
nit: for arrays, the [] form is preferred.
Contributor
Author
There was a problem hiding this comment.
Fixed in 0d0ffd9: switched to [] array syntax.
devnexen
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SoapServer::handle()ignored the return value ofobject_init_ex(), so when the class given tosetClass()could not be instantiated the code carried on with a NULL zval and crashed onZ_OBJCE_P(soap_obj). That happens for instance when a property default references an undefined constant, since evaluating it throws anErrorand object creation fails.Now the failure is reported as a SOAP fault, the same way a throwing constructor already is.
Fixes #23447